[libcxx-commits] [PATCH] D113253: [runtimes] Fix building initial libunwind+libcxxabi+libcxx with compiler implied -lunwind

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo added a comment.

In D113253#3112528 <https://reviews.llvm.org/D113253#3112528>, @phosek wrote:

> In D113253#3112450 <https://reviews.llvm.org/D113253#3112450>, @mstorsjo wrote:
>
>> Btw, what's your opinion on the compiler options added via `HandleLLVMOptions` - do they end up in the actual builds of runtimes, or are they just tested but left unused? As when building with `--unwindlib=none`, all of those fail due to the option causing warnings, so such builds would differ from other builds when the option isn't needed.
>
> From what I know some of the options are used by individual runtimes but not all of them. Furthermore, not all of the options are defined in `HandleLLVMOptions.cmake`. For example, `LLVM_ENABLE_MODULES` is defined in `llvm/CMakeLists.txt` and is used from both `HandleLLVMOptions.cmake` as well as `libcxx/CMakeLists.txt`.
>
> I think we should ideally go over all the LLVM options that are used in runtimes and split those into a separate top-level CMake module and then stop including both `AddLLVM.cmake` and `HandleLLVMOptions.cmake` from the runtimes build.

Thanks, that sounds like a good strategy.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113253/new/

https://reviews.llvm.org/D113253