[libcxx-commits] [PATCH] D113253: [runtimes] Fix building initial libunwind+libcxxabi+libcxx with compiler implied -lunwind

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo added a comment.

In D113253#3112382 <https://reviews.llvm.org/D113253#3112382>, @phosek wrote:

> In D113253#3112370 <https://reviews.llvm.org/D113253#3112370>, @mstorsjo wrote:
>
>> Hmm, for building the full compiler-rt at the same time as libunwind, for picking it up for use for the sanitizers etc? I currently build all of those in a separate invocation so it's not on my todo list right now... I guess that'd be needed to fix the full from-scratch cases with the llvm/runtimes ("bootstrap") build with no preexisting libunwind.
>
> That's our use case. I can look into that after this change lands.

Thanks!

Btw, what's your opinion on the compiler options added via `HandleLLVMOptions` - do they end up in the actual builds of runtimes, or are they just tested but left unused? As when building with `--unwindlib=none`, all of those fail due to the option causing warnings, so such builds would differ from other builds when the option isn't needed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113253/new/

https://reviews.llvm.org/D113253