[libcxx-commits] [PATCH] D113253: [runtimes] Fix building initial libunwind+libcxxabi+libcxx with compiler implied -lunwind

Fri Nov 5 11:34:55 PDT 2021

phosek added a comment.

In D113253#3112370 <https://reviews.llvm.org/D113253#3112370>, @mstorsjo wrote:

> In D113253#3112324 <https://reviews.llvm.org/D113253#3112324>, @phosek wrote:
>
>> I prefer this version over D113252 <https://reviews.llvm.org/D113252> because I'd like to avoid linker picking up libraries like libunwind implicitly as that seems more error prone.
>
> Yeah, this was my second approach, and I like this one better too.
>
> I'll amend it with the change so it doesn't break builds with ASAN/TSAN.
>
> In D113253#3112336 <https://reviews.llvm.org/D113253#3112336>, @phosek wrote:
>
>> LGTM do you also plan to include `--unwindlib=none` in compiler-rt build in a follow up change?
>
> Hmm, for building the full compiler-rt at the same time as libunwind, for picking it up for use for the sanitizers etc? I currently build all of those in a separate invocation so it's not on my todo list right now... I guess that'd be needed to fix the full from-scratch cases with the llvm/runtimes ("bootstrap") build with no preexisting libunwind.

That's our use case. I can look into that after this change lands.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113253/new/

https://reviews.llvm.org/D113253