[libcxx-commits] [PATCH] D70631: Microsoft's floating-point to_chars powered by Ryu and Ryu Printf

[Mark de Wever via Phabricator via libcxx-commits]

Mordante marked an inline comment as done.
Mordante added a comment.

In D70631#3111085 <https://reviews.llvm.org/D70631#3111085>, @floam wrote:

> The C++17 limitation sure seems hard to justify.

Since this is added to the Standard for C++17 and our current policy is not to backport features it will be limited to C++17 and later.
After moving the code to the dylib the reason stated for only enabling it in C++17 is just no longer the proper reason.

Enabling it for earlier versions may haunt us later. Maybe a paper will be written "Add `constexpr` Modifiers to Functions `to_chars` and `from_chars` for Floating-point Types in <charconv> Header"


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70631/new/

https://reviews.llvm.org/D70631