[libcxx-commits] [PATCH] D113252: [runtimes] Fix building initial libunwind+libcxxabi+libcxx with compiler implied -lunwind

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo added a comment.

Hmm, the CI failures show that `--unwindlib=none` does break cases when we're configuring with ASAN/TSAN, because those runtimes (which get implicitly linked everywhere during the cmake tests) do need the unwinder. Should we change the tests to first see if linking works without any flags added, and only try `--unwindlib=none` if linking otherwise fails?

Secondly, adding `--unwindlib=none` to `CMAKE_REQUIRED_FLAGS` does break a lot of other tests within `HandleLLVMOptions` (is that even needed when building runtimes, which are kinda disconnected from the things done in the main llvm dir?), as those tests check for options with `-Werror` (to avoid picking up options that do nothing but add warnings), because `--unwindlib=none` produces warnings when set while compiling (contrary to `-nostdlib++` which doesn't cause warnings if set while compiling).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113252/new/

https://reviews.llvm.org/D113252