[libcxx-commits] [PATCH] D112126: [libunwind] Try to add -unwindlib=none while configuring and building libunwind

Fri Nov 5 00:46:58 PDT 2021

phosek accepted this revision.
phosek added a comment.
This revision is now accepted and ready to land.

LGTM

================
Comment at: libunwind/CMakeLists.txt:28
+  # linking.
+  include(EnableLanguageNolink)
+  project(libunwind LANGUAGES NONE)
----------------
mstorsjo wrote:
> phosek wrote:
> > When reading through CMake modules, I noticed that some CMake platform modules set `_CMAKE_FEATURE_DETECTION_TARGET_TYPE ` (see https://github.com/Kitware/CMake/blob/master/Modules/Platform/iOS-Initialize.cmake#L9), this is then used by C and C++ compiler test, see https://github.com/Kitware/CMake/blob/4e84a4763d702590fb06d62540e35a614dcd5133/Modules/CMakeTestCCompiler.cmake#L17 and https://github.com/Kitware/CMake/blob/4e84a4763d702590fb06d62540e35a614dcd5133/Modules/CMakeTestCXXCompiler.cmake#L17.
> > 
> > I wonder if we can use `_CMAKE_FEATURE_DETECTION_TARGET_TYPE` here as well instead of wrapping `enable_language`.
> I guess we might be able to, but I guess `_CMAKE_FEATURE_DETECTION_TARGET_TYPE` is undocumented and shouldn't be used outside of cmake's own modules?
I've filed https://gitlab.kitware.com/cmake/cmake/-/issues/22859, we'll see what CMake maintainers think.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112126/new/

https://reviews.llvm.org/D112126