[libcxx-commits] [PATCH] D113139: [libc++] Mark a failing test.

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Nov 4 10:01:24 PDT 2021


Mordante added a comment.

In D113139#3107289 <https://reviews.llvm.org/D113139#3107289>, @Quuxplusone wrote:

>> it manipulates an iterator to a std::string returned from the dylib
>
> It would be nice to say in the commit message //which dylib function// is the culprit, and where in this 600-line test the iterator is being manipulated. (I'm aware of `std::to_string(int)` as a frequent culprit; I just don't know if that's the dylib function you're talking about in this specific case.)

It's numpunct's grouping and the issue is in `<format>` not in the test itself. I've added this information in the test.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113139/new/

https://reviews.llvm.org/D113139



More information about the libcxx-commits mailing list