[libcxx-commits] [PATCH] D113133: [libc++] Improve no wide characters configuration.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

Awesome, thanks a lot for looking into it!



================
Comment at: libcxx/src/locale.cpp:4588-4594
+static bool checked_string_to_char_convert(char& dest, const char* ptr, locale_t __loc) {
+  if (*ptr == '\0')
+    return false;
+  if (!ptr[1]) {
+    dest = *ptr;
+    return true;
+  }
----------------
This appears to be the same as the `checked_string_to_char_convert ` function above -- could we hoist it out of the `#if` to avoid duplication?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113133/new/

https://reviews.llvm.org/D113133