[libcxx-commits] [PATCH] D113139: [libc++] Mark a failing test.

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Nov 3 13:12:29 PDT 2021


Mordante created this revision.
Mordante added a reviewer: ldionne.
Mordante requested review of this revision.
Herald added a project: libc++.
Herald added a subscriber: libcxx-commits.
Herald added a reviewer: libc++.

The tests fails in debug mode since it manipulates an iterator to a
`std::string` returned from the dylib. This is a known issue for the
debug iterators.

Updating the libc++ Docker image to Ubuntu Focal caused some breakage.
This was temporary disabled in D112737 <https://reviews.llvm.org/D112737>. This re-enables one of these
tests.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D113139

Files:
  libcxx/test/std/utilities/format/format.functions/locale-specific_form.pass.cpp


Index: libcxx/test/std/utilities/format/format.functions/locale-specific_form.pass.cpp
===================================================================
--- libcxx/test/std/utilities/format/format.functions/locale-specific_form.pass.cpp
+++ libcxx/test/std/utilities/format/format.functions/locale-specific_form.pass.cpp
@@ -9,9 +9,7 @@
 // UNSUPPORTED: libcpp-no-concepts
 // UNSUPPORTED: libcpp-has-no-localization
 // UNSUPPORTED: libcpp-has-no-incomplete-format
-
-// TODO(mordante): Investigate these localization/format failures since updating the Docker image in CI
-// UNSUPPORTED: stdlib=libc++
+// XFAIL: LIBCXX-DEBUG-FIXME
 
 // REQUIRES: locale.en_US.UTF-8
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D113139.384565.patch
Type: text/x-patch
Size: 673 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20211103/8a44384f/attachment.bin>


More information about the libcxx-commits mailing list