[libcxx-commits] [PATCH] D113066: [libcxx][SystemZ][z/OS] Update libcxx/src/memory.cpp to accommodate POSIX(OFF)

Jon Roelofs via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Nov 3 11:15:48 PDT 2021


jroelofs added inline comments.


================
Comment at: libcxx/src/memory.cpp:152
 {
-    auto m = static_cast<__libcpp_mutex_t*>(__lx);
-    unsigned count = 0;
----------------
I'd leave the 4-space indentation alone, since that seems to be the local style in the rest of libcxx.


================
Comment at: libcxx/src/memory.cpp:195
     };
     return muts[hash<const void*>()(p) & (__sp_mut_count-1)];
 }
----------------
micro-optimization: when threading is disabled, always return `muts[0]`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113066/new/

https://reviews.llvm.org/D113066



More information about the libcxx-commits mailing list