[libcxx-commits] [PATCH] D111477: DO NOT SUBMIT: workaround for context-sensitive use of non-type-template-parameter integer suffixes

[David Blaikie via Phabricator via libcxx-commits]

dblaikie added a comment.

In D111477#3106171 <https://reviews.llvm.org/D111477#3106171>, @ldionne wrote:

> This broke libc++'s CI: https://buildkite.com/llvm-project/libcxx-ci/builds/6374#7569da95-c852-44f9-8b69-947245cf0b65
>
> When you make a change to Clang AND the libc++ tests at the same time, you have to account for the fact that we support older versions of Clang. For example, here, you changed the pretty printer test, but we still run that test with Clang 12 and Clang 13, not only with Clang `main`. Since older Clangs don't contain your change, the test fails (and rightfully so). I'll add the necessary `XFAIL`s, but please look out for these breakages since they are somewhat disruptive. Thanks!

Thanks for the context/fix - I'll try to keep it in mind.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111477/new/

https://reviews.llvm.org/D111477