[libcxx-commits] [PATCH] D112012: [benchmarks] Unify libcxx's fork of google/benchmark to llvm/utils

[Mircea Trofin via Phabricator via libcxx-commits]

mtrofin added a comment.

In D112012#3106555 <https://reviews.llvm.org/D112012#3106555>, @ldionne wrote:

> In D112012#3106549 <https://reviews.llvm.org/D112012#3106549>, @ldionne wrote:
>
>> However, we do need to fix the CI for libc++. Since you're moving the library to another place, we'll need to adjust the paths to it in `libcxx/`. I think this should be sufficient:
>> [...]
>
> Oh, sorry, I hadn't seen your changes to `libcxx/benchmark/CMakeLists.txt`. The issue now is that `LLVM_THIRD_PARTY_DIR` is only set in `llvm/CMakeLists.txt`. However, the runtimes don't use that directory anymore (in fact building the runtimes using `llvm/CMakeLists.txt` is deprecated). You'd have to set `LLVM_THIRD_PARTY_DIR` in `runtimes/CMakeLists.txt`.

Ah, I see - so in runtimes/CMakeLists.txt, if `LLVM_THIRD_PARTY_DIR` isn't set, then we set it there to ../third_party or something of that sort, correct?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112012/new/

https://reviews.llvm.org/D112012