[libcxx-commits] [PATCH] D112976: [libc++][NFC] Inline most of `__vector_base` into `vector`.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added inline comments.


================
Comment at: libcxx/include/vector:813
   }
+
+  _LIBCPP_INLINE_VISIBILITY
----------------
var-const wrote:
> philnik wrote:
> > Since you are moving this around, could you reformat to the LLVM style instead of keeping the old style?
> I'll see if I can get `clang-format` to work on this file. If that goes well, I'd rather do a separate patch for reformatting the whole file.
I think we should be wary about formatting the entire file. It may cause merge conflicts for patches under review. I'd rather see a separate patch to format only the new lines new part in this file.

When you do that can you directly do s/_LIBCPP_INLINE_VISIBILITY/_LIBCPP_HIDE_FROM_ABI/ for that part?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112976/new/

https://reviews.llvm.org/D112976