[libcxx-commits] [PATCH] D113048: [libcxxabi] Fix NO_THREADS version of test_exception_storage.pass.cpp

[Daniel McIntosh via Phabricator via libcxx-commits]

DanielMcIntosh-IBM added a comment.

In D113048#3105916 <https://reviews.llvm.org/D113048#3105916>, @ikudrin wrote:

> It is better to split the patch so that the fix is separated from other improvements.
>
> As for the other two patches, I am afraid I am not the right person to review them.

As for specifically the issue of splitting the patch up:

- The early returns kind of go hand in hand with fixing the NO_THREADS part of the test, since that's the only place we can do the early return, so I'm inclined to keep them together.
- arc won't let me submit it without removing the extra space on line 44
- for the cstdlib to cstddef change, I'd rather just drop it entirely, as I have done than create a separate review for it,


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113048/new/

https://reviews.llvm.org/D113048