[libcxx-commits] [PATCH] D113048: [libcxxabi] Tidy up test_exception_storage.pass.cpp, and fix the NO_THREADS version

[Daniel McIntosh via Phabricator via libcxx-commits]

DanielMcIntosh-IBM added a subscriber: jroelofs.
DanielMcIntosh-IBM added a comment.

In D113048#3104321 <https://reviews.llvm.org/D113048#3104321>, @jroelofs wrote:

> Looks ok to me, that said I'm not one of this project's group reviewers, so you'll need someone else's approval.

Thanks for the review (ish) @jroelofs. I'm aware that you're not one of the libc++ reviewers, but I still wanted your feedback because you were the author (and reviewer?) for D3386 <https://reviews.llvm.org/D3386>. In addition to being closely related to D113058 <https://reviews.llvm.org/D113058>, D113054 <https://reviews.llvm.org/D113054>, D113065 <https://reviews.llvm.org/D113065>, D113066 <https://reviews.llvm.org/D113066>, D113069 <https://reviews.llvm.org/D113069>, D112567 <https://reviews.llvm.org/D112567> and D110351 <https://reviews.llvm.org/D110351>, which basically  address a run-time dependent equivalent to NO_THREADS, it was also the change that introduced the `if (thread_code(&thread_globals) == 0)` line this change is supposed to fix.
With that in mind, even though you can't give the final approval, I still feel that your feedback on this and the others would be valuable.

Similarly, @ikudrin, I added you to this as well as D113054 <https://reviews.llvm.org/D113054> and D112567 <https://reviews.llvm.org/D112567> because of your authorship of D17815 <https://reviews.llvm.org/D17815>, which was somewhat related. I know in this case it isn't that closely related, but most of the people who //have// done related work are no longer active.

I now have a web of 16 inter-related changes and another 3 unrelated ones all mostly waiting on review by ldionne, which is a rather large review load for one person with other responsibilities. If I'm going to have any chance of landing them in a reasonable time frame, I need to spread it out a bit. Unfortunately, there aren't many people suitable for reviewing them who are still active other than Louis, so I would appreciate any feedback either of you can give on the changes I've requested your review of. Thank you in advance.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113048/new/

https://reviews.llvm.org/D113048