[libcxx-commits] [PATCH] D112958: [libcxx][NFC] tidy up money_get::__do_get's sign parsing

[Mark de Wever via Phabricator via libcxx-commits]

Mordante accepted this revision as: Mordante.
Mordante added a comment.

Thanks, this indeed looks better readable!
LGTM, but I prefer to remove the unneeded assignment.



================
Comment at: libcxx/include/locale:2969
+                ++__b;
+                __neg = false;
+                if (__psn.size() > 1)
----------------
The original algorithm never sets `__neg` to `false`. Looking at the code it seems the call-site always sets this value to `false`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112958/new/

https://reviews.llvm.org/D112958