[libcxx-commits] [PATCH] D112869: [libc++] Implement P2186R2 (Remove Garbage Collection)

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added inline comments.


================
Comment at: libcxx/src/legacy_pointer_safety.cpp:1
+//===----------------- legacy_pointer_safety.cpp --------------------------===//
+//
----------------
Please don't add the name of the file. We're trying to move away from that.


================
Comment at: libcxx/src/legacy_pointer_safety.cpp:12-13
+
+// pointer_safety functions are removed in C++23 and are not declared anymore in any C++ version in libc++.
+// They are defined here for ABI backwards compatibility.
+
----------------



================
Comment at: libcxx/src/legacy_pointer_safety.cpp:17-20
+void declare_reachable(void*) {}
+void declare_no_pointers(char*, size_t) {}
+void undeclare_no_pointers(char*, size_t) {}
+void* __undeclare_reachable(void* p) { return p; }
----------------
I believe that should fix your ABI list issues.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112869/new/

https://reviews.llvm.org/D112869