[libcxx-commits] [PATCH] D112976: [libc++][NFC] Inline most of `__vector_base` into `vector`.

Tue Nov 2 05:59:00 PDT 2021

ldionne accepted this revision.
ldionne added inline comments.
This revision is now accepted and ready to land.

================
Comment at: libcxx/include/vector:322-324
+    pointer                                                      __begin_;
+    pointer                                                      __end_;
+    __compressed_pair<pointer, allocator_type>                   __end_cap_;
----------------
var-const wrote:
> My understanding is that it's probably okay to move the member variables as well (from the ABI perspective), but I'd rather do that change in a follow-up.
Yes, I think it's OK to move them as long as we keep the order and we keep the same base classes.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112976/new/

https://reviews.llvm.org/D112976