[libcxx-commits] [PATCH] D112976: [libc++][NFC] Inline most of `__vector_base` into `vector`.

[Konstantin Varlamov via Phabricator via libcxx-commits]

var-const added inline comments.


================
Comment at: libcxx/include/vector:322-324
+    pointer                                                      __begin_;
+    pointer                                                      __end_;
+    __compressed_pair<pointer, allocator_type>                   __end_cap_;
----------------
My understanding is that it's probably okay to move the member variables as well (from the ABI perspective), but I'd rather do that change in a follow-up.


================
Comment at: libcxx/include/vector:436-439
+      {
+        __clear();
+        __alloc_traits::deallocate(__alloc(), this->__begin_, capacity());
+      }
----------------
It seemed that newer code in `vector` tends to use 2 spaces for indentation, so I reindented the older code I was moving around to be consistent with that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112976/new/

https://reviews.llvm.org/D112976