[libcxx-commits] [PATCH] D112904: [libc++] P0433R2: test that deduction guides are properly SFINAEd away.

[Konstantin Varlamov via Phabricator via libcxx-commits]

var-const added inline comments.


================
Comment at: libcxx/test/support/deduction_guides_sfinae_checks.h:174
+#ifdef _LIBCPP_VERSION
+  using OutputIter = std::insert_iterator<InstantiatedContainer>;
+#endif // _LIBCPP_VERSION
----------------
Note: alternatively, I could create a new struct for `OutputIter`, similar to the `priority_queue` test. Let me know if you'd prefer that.


================
Comment at: libcxx/test/support/deduction_guides_sfinae_checks.h:22
+template<template<typename ...> class Container>
+constexpr void SequenceContainerDeductionGuidesSfinaeAway() {
+  using Alloc = std::allocator<int>;
----------------
var-const wrote:
> Please let me know if you'd prefer shorter names for these functions.
(I mean `SequenceContainerDeductionGuidesSfinaeAway` and similar functions)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112904/new/

https://reviews.llvm.org/D112904