[libcxx-commits] [PATCH] D112869: [libc++] Implement P2186R2 (Remove Garbage Collection)

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone requested changes to this revision.
Quuxplusone added a comment.

LGTM mod Louis's comments! To fix the CI redness, you'll need to `git rm` the autogenerated header test file that is no longer being generated.
I think the new release note should go like this:

  API Changes
  -----------
  
  The declarations of functions `declare_reachable`, `undeclare_reachable`, `declare_no_pointers`,
  `undeclare_no_pointers`, and `get_pointer_safety` have been removed not only from C++2b but
  from all modes. Their symbols are still provided by the dynamic library for the benefit of
  existing compiled code. All of these functions have always behaved as no-ops.

(Technically `get_pointer_safety` is not a "no-op"; and `undeclare_reachable` is a template, not a function; but I don't think those technicalities are worth complicating the message.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112869/new/

https://reviews.llvm.org/D112869