[libcxx-commits] [libcxx] be34d5f - [libcxx] [test] Remove an incorrect TEST_HAS_ALIGNED_ALLOC define from test_macros.h

Martin Storsjö via libcxx-commits libcxx-commits at lists.llvm.org
Mon May 31 12:13:49 PDT 2021


Author: Martin Storsjö
Date: 2021-05-31T22:13:22+03:00
New Revision: be34d5f74afe8347b8b6110cb209186caf07e16b

URL: https://github.com/llvm/llvm-project/commit/be34d5f74afe8347b8b6110cb209186caf07e16b
DIFF: https://github.com/llvm/llvm-project/commit/be34d5f74afe8347b8b6110cb209186caf07e16b.diff

LOG: [libcxx] [test] Remove an incorrect TEST_HAS_ALIGNED_ALLOC define from test_macros.h

This was added inconsistently in
19fd9039ca242f408493b5c662f9d908eab8555e; Windows doesn't have the
aligned_alloc function (neither MSVC nor MinGW toolchains) and we don't
define _LIBCPP_HAS_ALIGNED_ALLOC while building libcxx.

Differential Revision: https://reviews.llvm.org/D103399

Added: 
    

Modified: 
    libcxx/test/libcxx/language.support/has_aligned_alloc.compile.pass.cpp
    libcxx/test/std/depr/depr.c.headers/stdlib_h.pass.cpp
    libcxx/test/std/language.support/support.runtime/cstdlib.pass.cpp
    libcxx/test/support/test_macros.h

Removed: 
    


################################################################################
diff  --git a/libcxx/test/libcxx/language.support/has_aligned_alloc.compile.pass.cpp b/libcxx/test/libcxx/language.support/has_aligned_alloc.compile.pass.cpp
index 5e863717ea39f..d1b41de5dc1a9 100644
--- a/libcxx/test/libcxx/language.support/has_aligned_alloc.compile.pass.cpp
+++ b/libcxx/test/libcxx/language.support/has_aligned_alloc.compile.pass.cpp
@@ -8,8 +8,6 @@
 
 // UNSUPPORTED: c++03, c++11, c++14
 
-// XFAIL: LIBCXX-WINDOWS-FIXME
-
 // Make sure TEST_HAS_ALIGNED_ALLOC (defined by the test suite) and
 // _LIBCPP_HAS_ALIGNED_ALLOC (defined by libc++) stay in sync.
 

diff  --git a/libcxx/test/std/depr/depr.c.headers/stdlib_h.pass.cpp b/libcxx/test/std/depr/depr.c.headers/stdlib_h.pass.cpp
index 8dd15c9e27c3c..295f51807d41f 100644
--- a/libcxx/test/std/depr/depr.c.headers/stdlib_h.pass.cpp
+++ b/libcxx/test/std/depr/depr.c.headers/stdlib_h.pass.cpp
@@ -8,8 +8,6 @@
 
 // test <stdlib.h>
 
-// XFAIL: LIBCXX-WINDOWS-FIXME
-
 #include <stdlib.h>
 #include <type_traits>
 #include <cassert>

diff  --git a/libcxx/test/std/language.support/support.runtime/cstdlib.pass.cpp b/libcxx/test/std/language.support/support.runtime/cstdlib.pass.cpp
index f2ff89db31c4c..668213f84838c 100644
--- a/libcxx/test/std/language.support/support.runtime/cstdlib.pass.cpp
+++ b/libcxx/test/std/language.support/support.runtime/cstdlib.pass.cpp
@@ -8,8 +8,6 @@
 
 // test <cstdlib>
 
-// XFAIL: LIBCXX-WINDOWS-FIXME
-
 #include <cstdlib>
 #include <type_traits>
 #include <cassert>

diff  --git a/libcxx/test/support/test_macros.h b/libcxx/test/support/test_macros.h
index 4bd3d55c5da47..3d8f933ee8b6f 100644
--- a/libcxx/test/support/test_macros.h
+++ b/libcxx/test/support/test_macros.h
@@ -209,7 +209,6 @@
 #  elif defined(_WIN32)
 #    if defined(_MSC_VER) && !defined(__MINGW32__)
 #      define TEST_HAS_QUICK_EXIT
-#      define TEST_HAS_ALIGNED_ALLOC
 #      define TEST_HAS_TIMESPEC_GET
 #    endif
 #  elif defined(__APPLE__)


        


More information about the libcxx-commits mailing list