[libcxx-commits] [PATCH] D103329: [libcxx][nfc] moves std `advance`, `next`, and `prev` into their headers

Christopher Di Bella via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon May 31 10:01:06 PDT 2021


cjdb added a comment.

In D103329#2789540 <https://reviews.llvm.org/D103329#2789540>, @ldionne wrote:

> I'm not a big fan of putting `std::advance` and `std::ranges::advance` in the same header - they are related but at the same time, they are fundamentally different things and have different dependencies. That's one reason why I preferred to split `ranges::` things into `<__ranges/XXXX.h>` instead. But I guess this will do, we can adjust in the future if need be.

Whatever we decide, it's better to keep `<iterator>` things inside `__iterator/` wherever possible (i.e. we should probably do `<__iterator/ranges/XXXX.h>`, not `<__ranges/XXXX.h>`).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103329/new/

https://reviews.llvm.org/D103329



More information about the libcxx-commits mailing list