[libcxx-commits] [PATCH] D103273: [libc++] Update all the pre-defined iterator types for C++20

Mon May 31 08:57:03 PDT 2021

ldionne accepted this revision as: libc++.
ldionne marked 3 inline comments as done.
ldionne added inline comments.
This revision is now accepted and ready to land.

================
Comment at: libcxx/include/iterator:863
+#if _LIBCPP_STD_VER > 17
+    _LIBCPP_INLINE_VISIBILITY constexpr back_insert_iterator() noexcept = default;
+#endif
----------------
Mordante wrote:
> Quuxplusone wrote:
> > I strongly recommend removing the redundant `constexpr` and `noexcept`, for cleanliness' sake. (Defaulted functions are always constexpr-auto and noexcept-auto.)
> > Ditto line 908, 1075, 1200; already OK on line 954.
> I've no strong opinion about this, but I slight prefer to use the wording the standard provides. Thus including `constexpr` and `noexept`.
Same as @Mordante , which is why I did it that way.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103273/new/

https://reviews.llvm.org/D103273