[libcxx-commits] [PATCH] D103399: [libcxx] [test] Remove an incorrect TEST_HAS_ALIGNED_ALLOC macro from test_macros.h

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo created this revision.
mstorsjo requested review of this revision.
Herald added a project: libc++.
Herald added a reviewer: libc++.

This was added inconsistently in
19fd9039ca242f408493b5c662f9d908eab8555e <https://reviews.llvm.org/rG19fd9039ca242f408493b5c662f9d908eab8555e>; Windows (neither MSVC nor
MinGW toolchains) doesn't have the aligned_alloc function and we don't
define _LIBCPP_HAS_ALIGNED_ALLOC while building libcxx.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D103399

Files:
  libcxx/test/libcxx/language.support/has_aligned_alloc.compile.pass.cpp
  libcxx/test/std/depr/depr.c.headers/stdlib_h.pass.cpp
  libcxx/test/std/language.support/support.runtime/cstdlib.pass.cpp
  libcxx/test/support/test_macros.h


Index: libcxx/test/support/test_macros.h
===================================================================
--- libcxx/test/support/test_macros.h
+++ libcxx/test/support/test_macros.h
@@ -209,7 +209,6 @@
 #  elif defined(_WIN32)
 #    if defined(_MSC_VER) && !defined(__MINGW32__)
 #      define TEST_HAS_QUICK_EXIT
-#      define TEST_HAS_ALIGNED_ALLOC
 #      define TEST_HAS_TIMESPEC_GET
 #    endif
 #  elif defined(__APPLE__)
Index: libcxx/test/std/language.support/support.runtime/cstdlib.pass.cpp
===================================================================
--- libcxx/test/std/language.support/support.runtime/cstdlib.pass.cpp
+++ libcxx/test/std/language.support/support.runtime/cstdlib.pass.cpp
@@ -8,8 +8,6 @@
 
 // test <cstdlib>
 
-// XFAIL: LIBCXX-WINDOWS-FIXME
-
 #include <cstdlib>
 #include <type_traits>
 #include <cassert>
Index: libcxx/test/std/depr/depr.c.headers/stdlib_h.pass.cpp
===================================================================
--- libcxx/test/std/depr/depr.c.headers/stdlib_h.pass.cpp
+++ libcxx/test/std/depr/depr.c.headers/stdlib_h.pass.cpp
@@ -8,8 +8,6 @@
 
 // test <stdlib.h>
 
-// XFAIL: LIBCXX-WINDOWS-FIXME
-
 #include <stdlib.h>
 #include <type_traits>
 #include <cassert>
Index: libcxx/test/libcxx/language.support/has_aligned_alloc.compile.pass.cpp
===================================================================
--- libcxx/test/libcxx/language.support/has_aligned_alloc.compile.pass.cpp
+++ libcxx/test/libcxx/language.support/has_aligned_alloc.compile.pass.cpp
@@ -8,8 +8,6 @@
 
 // UNSUPPORTED: c++03, c++11, c++14
 
-// XFAIL: LIBCXX-WINDOWS-FIXME
-
 // Make sure TEST_HAS_ALIGNED_ALLOC (defined by the test suite) and
 // _LIBCPP_HAS_ALIGNED_ALLOC (defined by libc++) stay in sync.
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D103399.348769.patch
Type: text/x-patch
Size: 1756 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20210531/808483a3/attachment-0001.bin>