[libcxx-commits] [PATCH] D103371: [libc++] Avoid `result_type` and `unary/binary_function` in <valarray>

Arthur O'Dwyer via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Sat May 29 14:31:42 PDT 2021


Quuxplusone added inline comments.


================
Comment at: libcxx/include/valarray:447
     _LIBCPP_INLINE_VISIBILITY
     value_type operator[](size_t __i) const {return __op_(__a0_[__i], __a1_[__i]);}
 
----------------
Btw, I was surprised to find `value_type` here instead of `result_type`. But changing it (or even trying to produce a test case where the difference was observable) seemed like a rabbit hole, so I avoided it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103371/new/

https://reviews.llvm.org/D103371



More information about the libcxx-commits mailing list