[libcxx-commits] [PATCH] D103369: [libc++] NFC: Move unwrap_iter to its own header

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Sat May 29 13:39:41 PDT 2021

Mordante added a comment.

In D103369#2788352 <https://reviews.llvm.org/D103369#2788352>, @Quuxplusone wrote:

> Well, my solution was to add this new header (and all new headers) to `module.modulemap`. So I assume this PR will fail buildkite as-is; it would need to add this header (and/or other new headers) to `module.modulemap` in order to keep buildkite happy. But I recommend people discuss the issue/solution(s) over on https://reviews.llvm.org/D102781#inline-979125 just to keep it all in the same place.

I agree it would be good to keep the discussion in D102781 <https://reviews.llvm.org/D102781>. This is mainly to test whether your approach also works here or more changes are required. The original patch broke the Linux builds. I tested Linux locally with only your `__iterator_iterator_traits_h` module applied and that fixed it locally.

  rG LLVM Github Monorepo



More information about the libcxx-commits mailing list