[libcxx-commits] [PATCH] D102632: [libcxx/cxxabi/unwind][AIX] Add an AIX target and config for testing.

[Jason Liu via Phabricator via libcxx-commits]

jasonliu added a comment.

LGTM on AIX perspective. 
FYI, we will need two reviewers from libc++ review group or the maintainer of libc++ project to approve before we could land.



================
Comment at: libcxx/utils/libcxx/test/target_info.py:163
+    def add_cxx_link_flags(self, flags):
+        flags += ['-lpthread', '-lc++abi', '-lunwind', '-latomic']
+
----------------
Just noting that this setup only works when we use libc++/libc++abi/libunwind stack.
In theory, libc++ could work with gcc and use what's in libstdc++ to replace libc++abi and libunwind. If that's the case, then this won't work any more. And we would need something similar to `LinuxLocalTI` above.
But I guess people have intention to make the above combination work could change this setup later when they needed. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102632/new/

https://reviews.llvm.org/D102632