[libcxx-commits] [PATCH] D103335: [libcxx][ranges] Adds `common_iterator`.

[Tim Song via Phabricator via libcxx-commits]

tcanens added inline comments.


================
Comment at: libcxx/include/__iterator/common_iterator.h:52
+
+    _Hold() = default;
+    constexpr _Hold(_Iter __iter) : __iter(_VSTD::move(__iter)) {}
----------------
This isn't going to work if either of them has a non-trivial special member function.

The exposition-only `variant` really solved a lot of problems in the specification that this will need to solve again.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103335/new/

https://reviews.llvm.org/D103335