[libcxx-commits] [PATCH] D103335: [libcxx][ranges] Adds `common_iterator`.

Christopher Di Bella via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri May 28 12:21:20 PDT 2021


cjdb added inline comments.


================
Comment at: libcxx/include/__iterator/common_iterator.h:99
+             assignable_from<const _I2, _Iter> && assignable_from<const _S2&, _Sent>
+  constexpr common_iterator& operator=(const common_iterator<_I2, _S2>& __other) {
+    __u = __other.__u;
----------------
zoecarver wrote:
> Note: all of these constexprs aren't required by the standard, but I'm filing an lwg issue for it. 
Please link the issue in this PR before submitting (it doesn't need to be in the patch itself).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103335/new/

https://reviews.llvm.org/D103335



More information about the libcxx-commits mailing list