[libcxx-commits] [PATCH] D103311: [libcxx] [test] Fix the _supportsVerify check on Windows by using hasCompileFlag

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo added inline comments.


================
Comment at: libcxx/utils/libcxx/test/format.py:18
 
 def _supportsVerify(config):
     """
----------------
ldionne wrote:
> So this is a little bit tricky. The thing is that the test format is used inside the DSL, and I'd like to avoid a chicken-and-egg problem. IOW, I see this as a layering violation - the testing format is intended to be the base most thing that doesn't have any other dependencies except Lit proper.
Hmm, ok, I see...

FWIW, would it make sense to memoize this function to get it cached? When I had a printout here, I saw quite a number of calls during a regular test run.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103311/new/

https://reviews.llvm.org/D103311