[libcxx-commits] [PATCH] D103273: [libc++] Update all the pre-defined iterator types for C++20

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a subscriber: tcanens.
ldionne added inline comments.


================
Comment at: libcxx/include/iterator:245
     typedef void                         pointer;
 
     explicit front_insert_iterator(Container& x);  // constexpr in C++20
----------------
Mordante wrote:
> I miss `constexpr front_insert_iterator() noexcept = default; // since C++20` and the implementation.
> `back_insert_iterator` has the same issue.
Good catch, somehow I missed those. Thanks.


================
Comment at: libcxx/include/iterator:465
+
+    constexpr ostreambuf_iterator() noexcept = default; // since C++20
     ostreambuf_iterator(ostream_type& s) noexcept;
----------------
@tcanens I think this one is missing from cppreference: https://en.cppreference.com/w/cpp/iterator/ostreambuf_iterator/ostreambuf_iterator


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103273/new/

https://reviews.llvm.org/D103273