[libcxx-commits] [PATCH] D96385: [libc++] [P1032] Finish constexpr-ifying <iterator>, <string_view>, <tuple>, <utility>.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added inline comments.


================
Comment at: libcxx/test/std/iterators/predef.iterators/insert.iterators/front.insert.iter.ops/front.insert.iter.cons/container.pass.cpp:1
 //===----------------------------------------------------------------------===//
 //
----------------
ldionne wrote:
> @Quuxplusone  You didn't constexpr-ify this test (the default constructor one) for `back_insert_iterator`. Can you please go back and make sure you didn't forget others?
Ugh, I mean the `constexpr explicit back_insert_iterator(Container&)` constructor, not the default constructor.

Also, it would be great to tidy this up at the top of the test files:

```
// explicit front_insert_iterator(Cont& x);
```

should become

```
// explicit front_insert_iterator(Cont& x); // constexpr in C++20
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96385/new/

https://reviews.llvm.org/D96385