[libcxx-commits] [PATCH] D103160: [libc++] Update ABI docs

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu May 27 08:49:13 PDT 2021

ldionne requested changes to this revision.
ldionne added a comment.
This revision now requires changes to proceed.

We need to decide whether the ABI version is something that can be selected by users when they use libc++, or whether it's something that's baked in when the library is built and shipped (usually by a vendor). In my opinion, the former doesn't make sense, because the ABI version has an influence on what is provided in the `.so` - so the behavior of the headers has to match exactly how the `.so` was built. I'd like to get a common understanding and agreement that this is how things should work.

If we're all on the same page with that, I would not mention the `_LIBCPP_ABI_VERSION` macro anywhere since it can be considered an implementation detail of the library. The only thing that really matters is the `LIBCXX_ABI_VERSION` CMake setting, which is set when libc++ is built/packaged. I would also drop the mention of `_LIBCPP_ABI_UNSTABLE`.

  rG LLVM Github Monorepo



More information about the libcxx-commits mailing list