[libcxx-commits] [PATCH] D103171: [libc++] Deprecate std::iterator and remove it as a base class

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone added inline comments.


================
Comment at: libcxx/include/__memory/raw_storage_iterator.h:33-35
+_LIBCPP_SUPPRESS_DEPRECATED_PUSH
+    : public iterator<output_iterator_tag, void, void, void, void>
+_LIBCPP_SUPPRESS_DEPRECATED_POP
----------------
Actually, one last thing I don't understand: What's the purpose of `_LIBCPP_SUPPRESS_DEPRECATED_PUSH` here, given that this entire file is already controlled by `#pragma GCC system_header`? Do we hit situations where we're actually seeing deprecation diagnostics from this and other system headers?
I know you didn't invent `_LIBCPP_SUPPRESS_DEPRECATED_PUSH`, so it must be solving //some// problem, but I don't get it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103171/new/

https://reviews.llvm.org/D103171