[libcxx-commits] [PATCH] D102912: [libunwind] AARCH64 use inline assembly for pointer authentication

[Peter Collingbourne via Phabricator via libcxx-commits]

pcc added inline comments.


================
Comment at: libunwind/src/DwarfInstructions.hpp:229
+                       "mov x16, %x1;\n\t"
+                       "hint %[key];\n\t"
+                       "mov %0, x17\n\t"
----------------
kitaisreal wrote:
> MaskRay wrote:
> > Just use `hint 0xe`?
> Discussed in previous comments that it make sense to be more specific and use constant.
(I would vote for the way you had this originally, FWIW.)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102912/new/

https://reviews.llvm.org/D102912