[libcxx-commits] [PATCH] D103171: [libc++] Deprecate std::iterator and remove it as a base class

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

SGTM some questions.



================
Comment at: libcxx/include/__memory/raw_storage_iterator.h:45
+    typedef void                pointer;
+    typedef void                reference;
+
----------------
Is it intended to change the types of these typedefs and the base class?


================
Comment at: libcxx/include/iterator:508
 
 template<class _Category, class _Tp, class _Distance = ptrdiff_t,
          class _Pointer = _Tp*, class _Reference = _Tp&>
----------------
Can we remove this class when `_LIBCPP_ABI_NO_ITERATOR_BASES` is defined?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103171/new/

https://reviews.llvm.org/D103171