[libcxx-commits] [PATCH] D102006: [libcxx][ranges] Add range.subrange.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante accepted this revision as: Mordante.
Mordante added a comment.

LGTM, except for the `[[nodiscard]]` on `empty()`. Please make sure the build passes CI before committing.



================
Comment at: libcxx/include/__ranges/subrange.h:159
+
+    [[nodiscard]] constexpr bool empty() const { return __begin == __end; }
+
----------------
This one shouldn't be `[[nodiscard]]` according to the Standard.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102006/new/

https://reviews.llvm.org/D102006