[libcxx-commits] [PATCH] D102563: [libcxx][iterator] adds `std::ranges::next`

[Christopher Di Bella via Phabricator via libcxx-commits]

cjdb updated this revision to Diff 347842.
cjdb marked 3 inline comments as done.
cjdb added a comment.

Applies @ldionne's feedback:

- removes `[[nodiscard]]` from `ranges::next` (per offline discussion: things not explicitly marked `[[nodiscard]]` in the wording to be on hold till after P2351R0 and P2377R0 are discussed in Library Evolution)
- removes `[[nodiscard]]` from tests
- splits single `next.pass.cpp` into four files, one for each overload


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102563/new/

https://reviews.llvm.org/D102563

Files:
  libcxx/include/CMakeLists.txt
  libcxx/include/__iterator/next.h
  libcxx/include/iterator
  libcxx/test/std/iterators/iterator.primitives/range.iter.ops/range.iter.ops.next/check_round_trip.h
  libcxx/test/std/iterators/iterator.primitives/range.iter.ops/range.iter.ops.next/constraints.verify.cpp
  libcxx/test/std/iterators/iterator.primitives/range.iter.ops/range.iter.ops.next/iterator.pass.cpp
  libcxx/test/std/iterators/iterator.primitives/range.iter.ops/range.iter.ops.next/iterator_count.pass.cpp
  libcxx/test/std/iterators/iterator.primitives/range.iter.ops/range.iter.ops.next/iterator_count_sentinel.pass.cpp
  libcxx/test/std/iterators/iterator.primitives/range.iter.ops/range.iter.ops.next/iterator_sentinel.pass.cpp
  libcxx/test/std/iterators/iterator.primitives/range.iter.ops/range.iter.ops.next/special_function.compile.pass.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D102563.347842.patch
Type: text/x-patch
Size: 21935 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20210526/062834fd/attachment-0001.bin>