[libcxx-commits] [PATCH] D101922: [libcxx][iterator] adds `std::ranges::advance`

[Christopher Di Bella via Phabricator via libcxx-commits]

cjdb updated this revision to Diff 347722.
cjdb added a comment.

Changes requested by @zoecarver:

- Replaces `x <= 0` check with `x == 0 or x == 1` check.

Changes requested by @quuxplusone:

- Replaces verify test with compile-time test.
- Adds comment explaining why something non-standard has been added to `std::ranges` in the test file.

Changes requested by @ldionne:

- Removes more `[[nodiscard]]` (still keeps a few that I think could result in bugginess).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101922/new/

https://reviews.llvm.org/D101922

Files:
  libcxx/include/CMakeLists.txt
  libcxx/include/__function_like.h
  libcxx/include/__iterator/advance.h
  libcxx/include/iterator
  libcxx/test/std/iterators/iterator.primitives/range.iter.ops/range.iter.ops.advance/advance.pass.cpp
  libcxx/test/std/iterators/iterator.primitives/range.iter.ops/range.iter.ops.advance/special_function.compile.pass.cpp
  libcxx/test/support/test_iterators.h
  libcxx/test/support/test_standard_function.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D101922.347722.patch
Type: text/x-patch
Size: 34932 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20210525/2b22b071/attachment-0001.bin>