[libcxx-commits] [PATCH] D102992: [libcxx][type_traits] deprecates `std::is_literal_type` and remove it for C++20

[Wmbat via Phabricator via libcxx-commits]

Wmbat added inline comments.


================
Comment at: libcxx/docs/UsingLibcxx.rst:266-267
 
+**_LIBCPP_ENABLE_CXX20_REMOVED_IS_LITERAL_TYPE**:
+  This macro is used to re-enable `is_literal_type` and `is_literal_type_v`.
 
----------------
Quuxplusone wrote:
> Excellent noticing of documentation. :) However, on closer inspection of p0619r4, I think you should:
> - rename to `_LIBCPP_ENABLE_CXX20_REMOVED_TYPE_TRAITS`
> - include `result_of` and `result_of_t` under the same switch
> - (and then you //won't// need to alphabetize, because `TY...`, unlike `IS...`, comes after `RA...`)
> 
> Then you can mark p0619 section D.13 as complete.
`result_of` and `result_of_t` don't look deprecated or removed yet (in the `type_traits` header). Should I add them under the `_LIBCPP_ENABLE_CXX20_REMOVED_TYPE_TRAITS` macro documentation and not touch the code? I think might be missing something (likely) here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102992/new/

https://reviews.llvm.org/D102992