[libcxx-commits] [PATCH] D103101: [libc++] Add _LIBCPP_ABI_NO_ITERATOR_BASES. Fix input/output iterators' difference_type for C++20.

[Zoe Carver via Phabricator via libcxx-commits]

zoecarver added a comment.

WDYT about/would it be possible to add a test that would fail if we had an ABI break, but doesn't because we don't break ABI with this change (so long as we're not using the unstable ABI)?



================
Comment at: libcxx/include/__config:97
+// Also, in C++14 and later, don't derive iterator types from std::iterator.
+#  define _LIBCPP_ABI_NO_ITERATOR_BASES
 // Enable optimized version of __do_get_(un)signed which avoids redundant copies.
----------------
Are there some docs we can stick this in? Maybe mention it's enabled by default for the unstable ABI (as it should be). 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103101/new/

https://reviews.llvm.org/D103101