[libcxx-commits] [PATCH] D102357: [libcxx] [test] Explain an XFAIL LIBCXX-WINDOWS-FIXME and convert into "UNSUPPORTED"

Martin Storsjö via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue May 25 13:05:03 PDT 2021


This revision was automatically updated to reflect the committed changes.
Closed by commit rGec402f1d5da0: [libcxx] [test] Explain an XFAIL LIBCXX-WINDOWS-FIXME and convert into… (authored by mstorsjo).

Changed prior to commit:
  https://reviews.llvm.org/D102357?vs=345150&id=347763#toc

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102357/new/

https://reviews.llvm.org/D102357

Files:
  libcxx/test/libcxx/input.output/filesystems/class.directory_entry/directory_entry.mods/last_write_time.pass.cpp


Index: libcxx/test/libcxx/input.output/filesystems/class.directory_entry/directory_entry.mods/last_write_time.pass.cpp
===================================================================
--- libcxx/test/libcxx/input.output/filesystems/class.directory_entry/directory_entry.mods/last_write_time.pass.cpp
+++ libcxx/test/libcxx/input.output/filesystems/class.directory_entry/directory_entry.mods/last_write_time.pass.cpp
@@ -9,7 +9,11 @@
 // UNSUPPORTED: c++03
 // ADDITIONAL_COMPILE_FLAGS: -I %S/../../../../../../src/filesystem
 
-// XFAIL: LIBCXX-WINDOWS-FIXME
+// This test relies on calling functions from the libcxx internal header
+// filesystem_common.h; the Windows implementation uses different
+// internals and doesn't provide the same set_file_times function as for
+// other platforms.
+// UNSUPPORTED: windows
 
 // <filesystem>
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D102357.347763.patch
Type: text/x-patch
Size: 844 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20210525/294e1037/attachment-0001.bin>


More information about the libcxx-commits mailing list