[libcxx-commits] [libcxx] ec402f1 - [libcxx] [test] Explain an XFAIL LIBCXX-WINDOWS-FIXME and convert into UNSUPPORTED

[Martin Storsjö via libcxx-commits]

Author: Martin Storsjö
Date: 2021-05-25T22:59:55+03:00
New Revision: ec402f1d5da02dfbdc87d031ff99d7dbcada336f

URL: https://github.com/llvm/llvm-project/commit/ec402f1d5da02dfbdc87d031ff99d7dbcada336f
DIFF: https://github.com/llvm/llvm-project/commit/ec402f1d5da02dfbdc87d031ff99d7dbcada336f.diff

LOG: [libcxx] [test] Explain an XFAIL LIBCXX-WINDOWS-FIXME and convert into UNSUPPORTED

This particular test relies on internal details from the libc++
filesystem implementation header, and those details are structured
differently in the implementation for Windows.

Differential Revision: https://reviews.llvm.org/D102357

Added: 
    

Modified: 
    libcxx/test/libcxx/input.output/filesystems/class.directory_entry/directory_entry.mods/last_write_time.pass.cpp

Removed: 
    


################################################################################
diff  --git a/libcxx/test/libcxx/input.output/filesystems/class.directory_entry/directory_entry.mods/last_write_time.pass.cpp b/libcxx/test/libcxx/input.output/filesystems/class.directory_entry/directory_entry.mods/last_write_time.pass.cpp
index 44f90b019223a..49a5168c38550 100644
--- a/libcxx/test/libcxx/input.output/filesystems/class.directory_entry/directory_entry.mods/last_write_time.pass.cpp
+++ b/libcxx/test/libcxx/input.output/filesystems/class.directory_entry/directory_entry.mods/last_write_time.pass.cpp
@@ -9,7 +9,11 @@
 // UNSUPPORTED: c++03
 // ADDITIONAL_COMPILE_FLAGS: -I %S/../../../../../../src/filesystem
 
-// XFAIL: LIBCXX-WINDOWS-FIXME
+// This test relies on calling functions from the libcxx internal header
+// filesystem_common.h; the Windows implementation uses 
diff erent
+// internals and doesn't provide the same set_file_times function as for
+// other platforms.
+// UNSUPPORTED: windows
 
 // <filesystem>