[libcxx-commits] [PATCH] D103003: [libcxxabi] Use ASan interface header for declaration. NFC

Shoaib Meenai via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Sun May 23 21:13:10 PDT 2021

smeenai created this revision.
smeenai requested review of this revision.
Herald added a project: libc++abi.
Herald added a subscriber: libcxx-commits.
Herald added a reviewer: libc++abi.

This was changed from using the header to using a forward declaration in
rGc4600ccf891c <https://reviews.llvm.org/rGc4600ccf891ca8290ee4fa0a3f2be235dd5963d0>, since older versions of the header didn't declare the
function. At this point, it's been declared for ~3.5 years, and it
should be pretty safe to assume that we can rely on the ASan interface
header to provide a declaration instead of needing to write our own.

  rG LLVM Github Monorepo



Index: libcxxabi/src/cxa_exception.cpp
--- libcxxabi/src/cxa_exception.cpp
+++ libcxxabi/src/cxa_exception.cpp
@@ -20,7 +20,7 @@
 #include "include/atomic_support.h"
 #if __has_feature(address_sanitizer)
-extern "C" void __asan_handle_no_return(void);
+#include <sanitizer/asan_interface.h>
 // +---------------------------+-----------------------------+---------------+

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D103003.347305.patch
Type: text/x-patch
Size: 451 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20210524/a4b32519/attachment.bin>

More information about the libcxx-commits mailing list