[libcxx-commits] [PATCH] D102992: [libcxx][type_traits] deprecates `std::is_literal_type` and remove it for C++20

[Christopher Di Bella via Phabricator via libcxx-commits]

cjdb added a comment.

Overall LGTM, thanks for working on this! Please also add a test to confirm that `std::is_literal_type` is deprecated in C++17.



================
Comment at: libcxx/test/std/utilities/meta/meta.unary/meta.unary.prop/is_literal_type.removed.verify.cpp:8-9
 //===----------------------------------------------------------------------===//
 
-// UNSUPPORTED: c++03, c++11, c++14
+// REQUIRES: c++20
 
----------------



================
Comment at: libcxx/test/std/utilities/meta/meta.unary/meta.unary.prop/is_literal_type.removed.verify.cpp:15-16
 
-#include <any>
-#include <type_traits>
-
-#include "test_macros.h"
+#pragma clang diagnostic ignored "-Wdeprecated-declarations"
+#pragma GCC diagnostic ignored "-Wdeprecated-declarations"
 
----------------
Please delete these two lines.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102992/new/

https://reviews.llvm.org/D102992