[libcxx-commits] [PATCH] D101729: [libcxx] deprecates `std::iterator` and removes it as a base class

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone added a comment.

In D101729#2776070 <https://reviews.llvm.org/D101729#2776070>, @cjdb wrote:

> In D101729#2774913 <https://reviews.llvm.org/D101729#2774913>, @Quuxplusone wrote:
>
>> @ldionne: I recommend my blog post https://quuxplusone.github.io/blog/2021/05/07/std-iterator-as-a-base-class/
>> and the full discussion in D102657 <https://reviews.llvm.org/D102657>. I'll even volunteer to make the "remove all base classes for iterators and function-objects, and drive-by fix the `reverse_iterator` explosion, under an ABI flag" solution PR; it'll just take a week or two before I'm guaranteed to have time for it.
>
> That's what this patch does?

This PR (D101729 <https://reviews.llvm.org/D101729>) currently doesn't do any of the three things I mentioned (remove base classes for iterators and function-objects, fix the `reverse_iterator` explosion, add an ABI flag). But I'd be happy to commandeer it; is that OK by you?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101729/new/

https://reviews.llvm.org/D101729