[libcxx-commits] [PATCH] D101729: [libcxx] deprecates `std::iterator` and removes it as a base class

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone added a comment.

Also, concretely, @ldionne I believe your (3) still does not solve the ABI break for `reverse_iterator<reverse_iterator<int*>>`.
Also also, if we //really// cared about ABI breaks, we would put a test on them. Do you have any interest in adding some simple platform-specific tests (`REQUIRES` a certain platform) for things like `static_assert(sizeof(std::reverse_iterator<...>) == ...)`? Then ABI breakage would correspond to buildkite breakage, and people wouldn't be so likely to do it by accident.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101729/new/

https://reviews.llvm.org/D101729