[libcxx-commits] [PATCH] D102941: [libcxx][gardening] Re-order includes across libcxx.

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri May 21 13:20:11 PDT 2021


ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

> This can also serve as a pseudo "announcement" for how we should order these headers going forward (note: double underscores go before other headers).

Rather -- we always sort alphabetically, which means double underscores go where they go: before non-underscored headers, but it's really just mechanical.



================
Comment at: libcxx/include/__ranges/data.h:13
 #include <__config>
 
 #include <__iterator/concepts.h>
----------------
We could remove the newline here and just include `__config` like any other header, in alphabetical order.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102941/new/

https://reviews.llvm.org/D102941



More information about the libcxx-commits mailing list