[libcxx-commits] [PATCH] D101476: [libcxx][ranges] Add ranges::data CPO.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added inline comments.


================
Comment at: libcxx/include/__ranges/data.h:50
+      { _VSTD::forward<_Tp>(__t) } -> __can_borrow;
+      { ranges::begin(_VSTD::forward<_Tp>(__t)) } -> contiguous_iterator;
+    };
----------------
cjdb wrote:
> Please use `iterator_t` instead of redefining it.
I'm ambivalent on this, since the wording in http://eel.is/c++draft/range.prim.data#2.4 clearly says `ranges::begin` instead of `iterator_t`. It might be an oversight in the standard.

@zoecarver I'll let you judge whether you want to keep it the way it is right now or apply Chris' suggestion.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101476/new/

https://reviews.llvm.org/D101476